On Tue, 21 Jul 2009, Eric Paris wrote:

> +
> + if ((addr < mmap_min_addr) && !capable(CAP_SYS_RAWIO))
> + return -EACCES;

Please make this check a static inline. Less chance of someone breaking it, or it having some subtle bug, and easier to maintain.

> address &= PAGE_MASK;
> +

Whitespace leak.

• James -- James Morris <jmorris@namei.org>

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.